Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu::intel: Do CPU feature detection in Rust. #2439

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

briansmith
Copy link
Owner

@briansmith briansmith commented Mar 4, 2025

It's easiest to review this PR commit-by-commit.

@briansmith briansmith self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 12 lines in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (0c128bf) to head (272682e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/cpu/intel.rs 89.74% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2439      +/-   ##
==========================================
+ Coverage   96.58%   96.59%   +0.01%     
==========================================
  Files         180      179       -1     
  Lines       21737    21722      -15     
  Branches      538      523      -15     
==========================================
- Hits        20995    20983      -12     
- Misses        626      635       +9     
+ Partials      116      104      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith force-pushed the b/fxsr-3 branch 2 times, most recently from 447f270 to b5065dd Compare March 4, 2025 16:36
extended_features_ecx = 0;
extended_features_ebx = 0;
}
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As codecov points out, and the comment notes, these lines are unreachable in unpatched versions of ring. (Some people do patch it in ways that make these lines reachable.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant