x86: Reduce harm when patched to remove the SSE2 requirement. #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
changed the title
briansmith
force-pushed
the
b/sse2-ssse3
branch
from
2f1ddbb to
00d02be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
==========================================
- Coverage 96.64% 96.63% -0.01%
==========================================
Files 176 176
Lines 21611 21627 +16
Branches 526 527 +1
==========================================
+ Hits 20885 20900 +15
- Misses 613 615 +2
+ Partials 113 112 -1 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/sse2-ssse3
branch
from
00d02be to
c03d5f4
Compare
briansmith
commented
Feb 11, 2025
| unsafe { | ||
| super::ffi::bn_mul_mont_ffi::<(), {MIN_LIMBS}, 1>(in_out, n, n0, (), | ||
| bn_mul_mont_fallback) | ||
| } |
There was a problem hiding this comment.
Codecov is right to complain that we don't test this branch in CI since we can't reach it without patching. This is intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.