Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes/x86/x86_64: Only use AES-NI when SSSE3 is available. #2359

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

briansmith
Copy link
Owner

Simplify feature detection logic. We don't have an easy way to test AES-NI without SSSE3, and it's not worth trying to hack something up.

@briansmith briansmith self-assigned this Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (6e04750) to head (bc307f6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2359   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         176      176           
  Lines       21611    21611           
  Branches      526      526           
=======================================
+ Hits        20886    20887    +1     
  Misses        613      613           
+ Partials      112      111    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Simplify feature detection logic. We don't have an easy way to test
AES-NI without SSSE3, and it's not worth trying to hack something up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant