Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes-gcm internals: Clarify processing of last partial block, if any #2207

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

briansmith
Copy link
Owner

No description provided.

@briansmith briansmith self-assigned this Jan 1, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.14%. Comparing base (a2a8e9b) to head (0dd3a35).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aead/overlapping/partial_block.rs 85.71% 2 Missing and 2 partials ⚠️
src/aead/overlapping/base.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
- Coverage   97.16%   97.14%   -0.03%     
==========================================
  Files         158      159       +1     
  Lines       20267    20298      +31     
  Branches      454      456       +2     
==========================================
+ Hits        19693    19719      +26     
- Misses        469      473       +4     
- Partials      105      106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith merged commit a97a354 into main Jan 2, 2025
156 of 158 checks passed
@briansmith briansmith deleted the b/in-out-partial branch January 2, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant