Use non-zero value when initializing test buffers #1157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Picking up from PRs #564 and #600:
UNINITIALIZED_U8
withvalue
0xDE
I tried to find every candidate in
tests/
and found a few tests frominside
src/
too.And I've opted to leave the buffers from
max_input_tests!
insrc/digest.rs
untouched as they are about the input length, but let meknow if you prefer otherwise.
Aside: the README recommends running
cargo test --no-default-features
prior to a PR but it fails to compile for me (Windows, WSL2 with Ubuntu
20.04) because the
test_file!
macro is gated by thealloc
feature.Running
cargo test --no-default-features --features alloc
works fine.