New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix underflow #1

Open

exp7l wants to merge 1 commit into brianmcmichael:master from exp7l:master

exp7l commented Jul 11, 2022

Hi, when I changed pragma to 0.8.x, the code fails at compile time because of underflow in L194 during the first mint.

    ├─ [52444] DSDeed::mint(0x00000000219ab540356cbb839cbe05303d7705fa, "t1") 
    │   └─ ← "Arithmetic over/underflow"
    └─ ← "Arithmetic over/underflow"

The call to _upush fixes upos, so data looks good to the caller.
I added a branch here so it will compile, should be good as a temporary fix.


          fix underflow

514e36e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet