More specific exception classes #911
Conversation
|
This looks good to me. Will need a rebase since the Ruby 1.9-syntax changes landed in another PR. Could you run down the unit test failures? |
casperisfine
force-pushed
the
more-specific-exception-classes
branch
2 times, most recently
from
aece179 to
6c271b5
Compare
|
@sodabrew sorry I should have checked CI after my rebase. I fixed the test suite. Should be good to go now. |
| def initialize(msg, server_version = nil, error_number = nil, sql_state = nil) | ||
| @server_version = server_version | ||
| @error_number = error_number | ||
| @sql_state = sql_state ? sql_state.encode(ENCODE_OPTS) : nil | ||
|
|
||
| super(clean_message(msg)) | ||
| end | ||
|
|
||
| def self.new_with_args(msg, server_version, error_number, sql_state) |
There was a problem hiding this comment.
I remember there was a reason for all of this, but I don't remember what that reason was 🤕
There was a problem hiding this comment.
I remember git blaming it and figuring out that it wasn't required anymore. Let me blame again.
There was a problem hiding this comment.
Hum, don't remember why I dimmed it unnecessary #545
I still think it's better this way, but I can remove that change if you prefer.
|
Thanks very much for the rebase and updating the unit tests! |
|
LGTM. Do you want to wait for feedback from the other folks you tagged in the OP? |
casperisfine
force-pushed
the
more-specific-exception-classes
branch
from
6c271b5 to
eb48219
Compare
No don't worry, they're coworkers, I'll ping them more directly. And since I had to rebase again, I'd rather get this merged ASAP :p |
|
Thanks for doing this 👍 |
* master: GitHub is HTTPS by default (brianmario#922) Fix wrong value of type YEAR on big endian environment. (brianmario#921) Avoid 0 byte allocation call when statement takes no parameters Small spec improvement for RSpec style Travis CI for Mac OS X builds use the same steps again More specific exception classes (brianmario#911) Travis CI matrix add Ruby 2.5 and switch Mac OS X to Ruby 2.3 (ala High Sierra) README text for query options on Statement#execute Accept query options on Statement#execute (brianmario#912) Drop 1.9.3 support (brianmario#913)
This follows up rails#36692, `Mysql2::Error::TimeoutError` is introduced from mysql2 gem 0.5.0. brianmario/mysql2#911
Take over: #870
Partially fix: #404
I've just implemented 2 of them to showcase what it could look like. I can go over all error codes if dimmed necessary.
(Sorry for opening a second PR, but long story short I lost access to the first fork I did).
@sodabrew does this look good to you?
cc @rafaelfranca & @sgrif