Improve prepared statement ergonomics #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
commented
Dec 3, 2024
sodabrew
reviewed
Dec 3, 2024
sodabrew
reviewed
Dec 3, 2024
byroot
force-pushed
the
stmt-double-close
branch
2 times, most recently
from
714659c to
5061154
Compare
byroot
commented
Dec 3, 2024
| # https://github.com/bbatsov/rubocop/pull/4789 | ||
| gem 'rubocop', '~> 1.30', '>= 1.30.1' if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.6') | ||
| # 1.51 is the last version supporting Ruby 2.6 | ||
| gem 'rubocop', '>= 1.30.1', '< 1.51' if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.6') |
There was a problem hiding this comment.
This should ensure a consistent rubocop result in local and CI.
byroot
force-pushed
the
stmt-double-close
branch
from
5061154 to
7b85b44
Compare
sodabrew
reviewed
Dec 3, 2024
byroot
force-pushed
the
stmt-double-close
branch
2 times, most recently
from
c866ab4 to
ef14593
Compare
While working on Mysql2 prepared statement support in Rails, I found them very hard to use. Most notably we sometimes need to close them eagerly, but it's complicated by the fact that you can only call `close` once, any subsequent call raises an error instead of just nooping. There's also no way to check if a statement was closed or not.
byroot
force-pushed
the
stmt-double-close
branch
from
ef14593 to
7d1bf1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on Mysql2 prepared statement support in Rails, I found them very hard to use. Most notably we sometimes need to close them eagerly, but it's complicated by the fact that you can only call
closeonce, any subsequent call raises an error instead of just nooping.There's also no way to check if a statement was closed or not.
cc @sodabrew @tenderlove