-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make a contribution guide #245
Comments
Are we review then commit, @cmccoy? I'd be in favor of adopting it as our policy. For folks who aren't familiar, that would mean maintainers are on the same footing as other contributors: someone else has to agree that a change is ready for merge before things are pushed into the main repo. Given our current low maintainer count, I'd be fine with accepting community reviews as authoritative (regardless they'd be lovely to have). |
On May 23, 2015 8:17 AM, "Sean Busbey" notifications@github.com wrote:
Me too, especially for code changes.
|
include expectations for adding new bindings / workloads
|
make sure to remind folks that we expect to work on Windows |
other guidance that I don't see above that we've discussed:
|
As noted in #596:
|
We should just make a CONTRIBUTING.md and have Github handle displaying it. https://github.com/blog/1184-contributing-guidelines |
Also addressed @jasontedor review, thanks!
Make a short guide for new contributors
The text was updated successfully, but these errors were encountered: