Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a contribution guide #245

Closed
busbey opened this issue May 18, 2015 · 8 comments
Closed

make a contribution guide #245

busbey opened this issue May 18, 2015 · 8 comments
Milestone

Comments

@busbey
Copy link
Collaborator

busbey commented May 18, 2015

Make a short guide for new contributors

  • include pointers to get access to code, issue tracker, mailing list
  • include style guide
  • include pr guidance
  • include licensing guidance
  • include expectations around releases
@busbey
Copy link
Collaborator Author

busbey commented May 23, 2015

Are we review then commit, @cmccoy? I'd be in favor of adopting it as our policy.

For folks who aren't familiar, that would mean maintainers are on the same footing as other contributors: someone else has to agree that a change is ready for merge before things are pushed into the main repo.

Given our current low maintainer count, I'd be fine with accepting community reviews as authoritative (regardless they'd be lovely to have).

@cmccoy
Copy link
Collaborator

cmccoy commented May 23, 2015

On May 23, 2015 8:17 AM, "Sean Busbey" notifications@github.com wrote:

Are we review then commit, @cmccoy? I'd be in favor of adopting it as our
policy.

Me too, especially for code changes.
I'm heading out if town for the weekend, but will catch up Monday or so.

For folks who aren't familiar, that would mean maintainers are on the
same footing as other contributors: someone else has to agree that a change
is ready for merge before things are pushed into the main repo.

Given our current low maintainer count, I'd be fine with accepting
community reviews as authoritative (regardless they'd be lovely to have).


Reply to this email directly or view it on GitHub.

@busbey
Copy link
Collaborator Author

busbey commented May 29, 2015

include expectations for adding new bindings / workloads

  • require a README that walks through running a load and a workload (for both bindings and workloads)
  • javadocs
  • example properties

@busbey
Copy link
Collaborator Author

busbey commented May 29, 2015

make sure to remind folks that we expect to work on Windows

@kruthar
Copy link
Collaborator

kruthar commented Nov 23, 2015

Additional note as per @busbey comments on #500.

YCSB clients should default to the strictest consistency available and document consistency tuning and tradeoffs in their readme.

@busbey
Copy link
Collaborator Author

busbey commented Nov 25, 2015

other guidance that I don't see above that we've discussed:

  • no client side buffering by default (but if you allow it please document how to use it and the tradeoffs)
  • document which specific version(s) of the datastore you expect to work with
  • document any set up of the datastore needed (like how some systems need to create a table with a particular schema)

@risdenk
Copy link
Collaborator

risdenk commented Jan 25, 2016

As noted in #596:

in general bindings should be in their own package

@risdenk
Copy link
Collaborator

risdenk commented Jan 19, 2017

We should just make a CONTRIBUTING.md and have Github handle displaying it. https://github.com/blog/1184-contributing-guidelines

@risdenk risdenk added this to the 0.13.0 milestone Jan 19, 2017
manolama added a commit to manolama/YCSB that referenced this issue Sep 19, 2017
manolama added a commit to manolama/YCSB that referenced this issue Sep 19, 2017
manolama added a commit to manolama/YCSB that referenced this issue Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants