eslint: enable rule: @typescript-eslint/no-unused-vars #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Jun 6, 2024
alxndrsn
commented
Jun 6, 2024
| }, | ||
| "rules": { | ||
| "@typescript-eslint/no-unused-vars": ["error", { | ||
| "args": "none" |
There was a problem hiding this comment.
Unused arguments are declared in a lot of places, and it could be argued they convey information about APIs being overwritten, or opportunities for extension e.g.
node-postgres/packages/pg/lib/query.js
Line 122 in a24a24d
alxndrsn
commented
Jun 6, 2024
When enabling this rule, it's recommended to also *disable* the standard `no-unused-vars` rule. Although `no-unused-vars` is not currently enabled, it seems helpful to explicitly disable it here. See: https://typescript-eslint.io/rules/no-unused-vars/
alxndrsn
force-pushed
the
eslint-no-unused
branch
from
6387a9f to
0bedff4
Compare
|
hey nice! sorry for the delay - was in colorado for some family visiting. back now. merging! thanks for doing this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling this rule, it's recommended to also disable the standard
no-unused-varsrule. Althoughno-unused-varsis not currently enabled, it seems helpful to explicitly disable it here.See: https://typescript-eslint.io/rules/no-unused-vars/