Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

report: "the connection pool didn't work for me" #46

Closed
kevinburkeshyp opened this issue Mar 30, 2016 · 5 comments
Closed

report: "the connection pool didn't work for me" #46

kevinburkeshyp opened this issue Mar 30, 2016 · 5 comments

Comments

@kevinburkeshyp
Copy link

According to @vitaly-t, attempting to swap pg for pg-native failed because the connection pool didn't work: brianc/node-postgres#972 (comment)

I don't have any more details, but figured it was worth reporting, to try and solicit more information.

@vitaly-t
Copy link

vitaly-t commented Apr 5, 2016

It is was probably too harsh to say that it doesn't work at all. But I have tons of tests failing when trying to change from the JavaScript version.

I have started looking into it in detail.

kevinburkeshyp pushed a commit to Shyp/sails-postgresql that referenced this issue Apr 5, 2016
This change requires a lot of work to achieve API compatibility with
node-postgres, at the very least there's a report of a problem with connection
pools, in addition the error objects have a completely different format in
pg-native.

- brianc/node-pg-native#46
- brianc/node-postgres#972
kevinburkeshyp pushed a commit to Shyp/sails-postgresql that referenced this issue Apr 5, 2016
This change requires a lot of work to achieve API compatibility with
node-postgres, at the very least there's a report of a problem with connection
pools, in addition the error objects have a completely different format in
pg-native.

- brianc/node-pg-native#46
- brianc/node-postgres#972
@vitaly-t
Copy link

vitaly-t commented Apr 6, 2016

I have finished my work with this within pg-promise. I was able to get it all to work, and released it with version 3.5.0.

Although I did run into many problems while doing this:

  • Different errors being reported
  • Different processing for empty or null queries
  • Impossible to determine JavaScript types for testing (being native)

It wouldn't be fair to say that it doesn't work at all.

I think this issue should be closed here.

@vitaly-t
Copy link

@kevinburkeshyp do you want to close this issue now?

@vitaly-t
Copy link

vitaly-t commented Aug 20, 2016

@brianc this issue should have been closed awhile ago.

@brianc
Copy link
Owner

brianc commented Aug 20, 2016

👍 thanks!

@brianc brianc closed this as completed Aug 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants