-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nan #39
Update nan #39
Conversation
Node v6 is out now, and libpq currently does not build on it. |
Hey @Qard - I really appreciate you putting this together. One small request: can you add v6 to the |
Node v6 is incoming, and nan 2.2.x is needed to support it.
Looks like it's having issues due to nodejs/node#6228, actually. I think it'll have to wait for another version of nan. |
The fix has been merged (nodejs/nan@00dacf0) and published as nan@2.3.0. |
@@ -17,7 +17,7 @@ | |||
"author": "Brian M. Carlson", | |||
"license": "MIT", | |||
"dependencies": { | |||
"nan": "^2.0.4", | |||
"nan": "^2.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^2.3.0
?
Closing, as this appears to be fixed by #41. Thanks! |
thank YOU On Fri, Apr 29, 2016 at 4:10 PM, Stephen Belanger notifications@github.com
|
Node v6 is incoming, and nan 2.2.x is needed to support it.