Improvements for SWC file loading #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many files on neuromorpho.org have deviations up to 0.05µm
Also, do not needlessly use recursion when following compartment chains. Otherwise we can run into recursion errors for long morphologies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardized SWC files on neuromorpho.org use the three-point soma representation, but in practice they are usually a bit off (i.e. the two exterior points are not at exactly one radius away from the center point). This PR makes our conversion code less strict to load these files. It also fixes an error that prevented the related error message to display correctly. Finally, the previous code used recursion even for going along chains of compartments, which could lead to
RecursionErrors for big morphologies. This has been replaced by simpler loops.See discussion on the Brian discourse group for context.