Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing dependencies #1577

Merged
merged 3 commits into from
May 8, 2020
Merged

Added missing dependencies #1577

merged 3 commits into from
May 8, 2020

Conversation

cowwoc
Copy link
Contributor

@cowwoc cowwoc commented May 7, 2020

No description provided.

@cowwoc
Copy link
Contributor Author

cowwoc commented May 7, 2020

@brettwooldridge So good news. module-info.java is being found. But it was missing some dependencies. Please let me know once the new SNAPSHOT is ready for testing.

@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #1577 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #1577   +/-   ##
=========================================
  Coverage     70.11%   70.11%           
  Complexity      561      561           
=========================================
  Files            26       26           
  Lines          2118     2118           
  Branches        297      297           
=========================================
  Hits           1485     1485           
  Misses          487      487           
  Partials        146      146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb6381...0953182. Read the comment docs.

@cowwoc
Copy link
Contributor Author

cowwoc commented May 7, 2020

If I don't copy the class files over, I get the following error:

C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:14: error: package is empty or does not exist: com.zaxxer.hikari
   exports com.zaxxer.hikari;
                     ^
C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:15: error: package is empty or does not exist: com.zaxxer.hikari.hibernate
   exports com.zaxxer.hikari.hibernate;
                            ^
C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:16: error: package is empty or does not exist: com.zaxxer.hikari.metrics
   exports com.zaxxer.hikari.metrics;
                            ^
C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:17: error: package is empty or does not exist: com.zaxxer.hikari.metrics.dropwizard
   exports com.zaxxer.hikari.metrics.dropwizard;
                                    ^
C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:18: error: package is empty or does not exist: com.zaxxer.hikari.metrics.micrometer
   exports com.zaxxer.hikari.metrics.micrometer;
                                    ^
C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:19: error: package is empty or does not exist: com.zaxxer.hikari.metrics.prometheus
   exports com.zaxxer.hikari.metrics.prometheus;
                                    ^
C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:20: error: package is empty or does not exist: com.zaxxer.hikari.pool
   exports com.zaxxer.hikari.pool;
                            ^
C:\Users\Gili\Documents\HikariCP\src\main\java11\module-info.java:21: error: package is empty or does not exist: com.zaxxer.hikari.util
   exports com.zaxxer.hikari.util;
                            ^
8 errors

I tried various tricks but couldn't figure it out so I think we're going to have to keep it for now.

@brettwooldridge
Copy link
Owner

@cowwoc New snapshot deployed.

@brettwooldridge
Copy link
Owner

@cowwoc Let me know if it works. 4am here in Japan, so I'll be headed off to bed shortly and will pick it up tomorrow.

@brettwooldridge
Copy link
Owner

brettwooldridge commented May 7, 2020

@cowwoc of course you can build a local jar with mvn clean package -Dmaven.test.skip=true.

@cowwoc
Copy link
Contributor Author

cowwoc commented May 7, 2020

@brettwooldridge Good point. Fortunately we're done. The latest SNAPSHOT works for me.

@brettwooldridge brettwooldridge merged commit 1d05b0e into brettwooldridge:dev May 8, 2020
@cowwoc cowwoc deleted the java11-support branch May 8, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants