add push command #23
Merged
add push command #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzix
reviewed
Feb 23, 2022
etc/bash_completion.sh
Outdated
| @@ -1,4 +1,4 @@ | |||
| _git_vendor() | |||
| { | |||
| __gitcomp "add list update" | |||
| __gitcomp "add list update push" | |||
There was a problem hiding this comment.
i think upstream better describes the operation
alzix
reviewed
Feb 23, 2022
man/git-vendor.md
Outdated
| @@ -11,13 +11,15 @@ git-vendor(1) -- manage vendored dependency subtrees | |||
|
|
|||
| `git-vendor update <name> [<ref>]` | |||
|
|
|||
| `git-vendor push <name> [<ref>]` | |||
There was a problem hiding this comment.
add new optional argument that can override $repository as in most cases you will not have write access to the origin repo and if you want to upstream your changes you would need to:
- fork
- upstream to the fork-repo
- create pull- request from the fork-repo to the original repo
There was a problem hiding this comment.
for this I will need to parse the arguments and add the new optional argument with an option name to distinguish between ref and repo like:
git vendor upstream [--repo repository] and optional ref
…n override $repository
Co-authored-by: Brett Langdon <me@brett.is>
Co-authored-by: Brett Langdon <me@brett.is>
brettlangdon
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to push back our changes to the remote repository