Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typing_extensions requirement to >=4.13.0 #276

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Mar 20, 2025

Summary

  • Remove workaround for Optional[Annotated[]] ordering in Python 3.8-3.10
  • Fix isinstance() error for TypeAliasType between typing and typing_extensions
  • Enable test_tuple_custom_constructors_positional_default_none in Python 3.8+

Addresses #260

🤖 Generated with Claude Code

1. Remove workaround for Optional[Annotated[]] ordering in Python 3.8-3.10
2. Fix isinstance() error for TypeAliasType between typing and typing_extensions
3. Enable test_tuple_custom_constructors_positional_default_none in Python 3.8+

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (a97163e) to head (12a9ba5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          33       33           
  Lines        2324     2327    +3     
=======================================
+ Hits         2320     2323    +3     
  Misses          4        4           
Flag Coverage Δ
unittests 99.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Properly cast TypeAliasType to avoid attribute access errors
- Add type ignore comment for Annotated return type
- Addresses type checking failures in CI

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant