-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vcfanno does not typecast fields correctly when using the by_alt op #113
Comments
thanks for the clear report. i'll see if i can get a fix in shortly |
Hi, this was an easy fix. If you want you can try the (linux) binary attached here. And I should have a release out before august. |
brentp
added a commit
that referenced
this issue
Jul 19, 2019
Swift response. Thank you, @brentp! |
this is out in new release. |
Thank you, @brentp. I verified vcfanno 0.3.2 |
cheers. thanks for following up and for providing the great test-case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to https://github.com/brentp/vcfanno#typecasting-values, it should be possible to typecast fields by adding a
_float
suffix to the field names. However, when using theby_alt
op, the annotated VCF fields do not have the desired type, and the_float
suffixes are not removedOp:
self
Field name: good
Field number: bad
Field type: float
Op:
by_alt
Field name: bad
Field number: good
Field type: string
It would be good if the following was true:
by_alt
minimal conf and lua files that you are using.
See above
urls or actual files for annotations in conf file.
the command you used to invoke vcfanno
See above
the full error message
None
The text was updated successfully, but these errors were encountered: