Also include xray with jQuery3 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
requested changes
May 3, 2017
lib/xray/middleware.rb
Outdated
| @@ -100,7 +100,7 @@ def script_matcher(script_name) | |||
| / | |||
| <script[^>]+ | |||
| \/#{script_name} | |||
| (2)? # Optional 2 for jQuery2 format | |||
| (2|3)? # Optional 2 for jQuery2 format | |||
There was a problem hiding this comment.
Can you also update the comment?
|
Updated! |
mattbrictson
requested changes
May 4, 2017
CHANGELOG.md
Outdated
| @@ -10,7 +10,8 @@ lesser changes or bug fixes. | |||
|
|
|||
| ## [Unreleased][] | |||
|
|
|||
| * Your contribution here! | |||
There was a problem hiding this comment.
Sorry, I should have specified. Can you please put the * Your contribution here! back in? Thanks!
|
I think everything is fine now! |
|
Great, thanks for the contribution! 🙇 |
mattbrictson
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.