Fix Rails 3.2 compatibility by not using try
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nnc Can you test my branch and verify it fixes the Rails 3.2 problem you're having? Thanks! |
The ActiveSupport `try` method works differently in different versions of Rails. In some versions it checks `respond_to?`; others do not. It is safer (and more compatible) to explicitly use `respond_to?` instead.
mattbrictson
force-pushed
the
fix-rails-32
branch
from
9ef59eb to
597947d
Compare
|
@mattbrictson works like a charm. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActiveSupport
trymethod works differently in different versions of Rails. In some versions it checksrespond_to?; others do not. It is safer (and more compatible) to explicitly userespond_to?instead.Fixes #71