Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Sprockets 4 #103

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Adapt to Sprockets 4 #103

merged 1 commit into from
Nov 17, 2019

Conversation

cohei
Copy link
Contributor

@cohei cohei commented Oct 18, 2019

calling non-existent method 'pathname'
#88

calling non-existent method 'pathname'
#88
@cohei cohei closed this Oct 18, 2019
@cohei cohei deleted the sprockets4 branch October 18, 2019 12:37
@mattbrictson
Copy link
Collaborator

This looks like a good fix. I'm curious, why did you close it?

@cohei cohei restored the sprockets4 branch October 27, 2019 16:09
@cohei
Copy link
Contributor Author

cohei commented Oct 27, 2019

I intended internal use but made this pull request by mistake. So I didn't check enough. For example, whether it still works on sprockets 3.

The change is just from #88. You can open a new pull request with the same change by looking that if you want.

However, there is no big reason for closing this. Well, I'll reopen it.

@cohei cohei reopened this Oct 27, 2019
@KevinBongart
Copy link

@mattbrictson @brentd Let's get this bugfix in? One-liner that fixes an issue with Sprockets 4 which is getting more and more adoption with Rails 6.0.1 out.

@mattbrictson
Copy link
Collaborator

Thanks for the fix!

@mattbrictson mattbrictson merged commit 4f6cca0 into brentd:master Nov 17, 2019
@arman-h
Copy link

arman-h commented Jan 31, 2020

Would you mind making a release with this bugfix in it? It would be useful to get this for apps running Rails 6. The last release (0.3.2) was almost a year ago.

@mattbrictson
Copy link
Collaborator

Unfortunately this PR does not completely provide compatibility with Rails 6 and Sprockets 4. See discussion at #88 (comment) and #105.

The current release of xray-rails (0.3.2) does work with Rails 6, as long as you pin to sprockets ~> 3.5.

alephyud added a commit to alephyud/rails-template that referenced this pull request Feb 9, 2020
Have to install an unreleased version to work around
this bug: brentd/xray-rails#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants