Changes from update_attributes to assignment #56
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks position column as not attr_accessible (like it is in many apps)
and sets the column by directly setting the attribute.
Fixes issue #50
I don't know if there was a reason for using update_attributes!, I couldn't
find any. This patch adds
set_list_position
public method. It could alsobe private but there are few tests that used update_attributes! which I
converted to use the new
set_list_position
method.This way of fixing the problem doesn't make acts_as_list dependent of
attr_accessible
like #51which is nice considering strong_parameters seems to be the future.