Improvements to gl_generator API #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzab
changed the title
brendanzab
force-pushed
the
rename-ns
branch
from
0e632b0 to
9ad653f
Compare
brendanzab
changed the title
brendanzab
force-pushed
the
rename-ns
branch
from
a49ead9 to
c082aeb
Compare
brendanzab
changed the title
brendanzab
force-pushed
the
rename-ns
branch
2 times, most recently
from
b0bd9de to
668dabb
Compare
This is some code that is related to binding generation that is hanging around in the registry module. Better to move it into the generators module.
As discussed in #338, this means that users no longer need to depend on khronos_api.
Improved type safety, and more self-documenting!
These types now implement Read and Write, so the extra BufReaders and BufWriter structs are not required. Not sure if this makes any difference to performance.
The 'Builder' suffix doesn't make sense here - it is normally used for denoting stucts that provide Builder APIs. 'Parser' seems more appropriate here.
This is only used internally, and does not need to be exposed
brendanzab
force-pushed
the
rename-ns
branch
from
668dabb to
4a6a030
Compare
brendanzab
force-pushed
the
rename-ns
branch
from
4a6a030 to
a7fa0f8
Compare
brendanzab
added a commit
that referenced
this pull request
Nov 29, 2015
Improvements to gl_generator API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #338
Part of this work is going towards having a simpler external API, and a simpler, more maintainable internal implementation. I'm also trying to update the docs as I go - there is lots of obsolete stuff there, related to when we used expose a syntax extension pre-1.0.