Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record_id to notifications endpoint #17

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

hydra-yse
Copy link
Member

This allows the client to check whether or not they were the one broadcasting the record.

P.S. May also be useful to add the new latest revision, but for the SDK's purposes the record id is all that's required.

@hydra-yse hydra-yse requested a review from roeierez February 17, 2025 00:28
@hydra-yse hydra-yse self-assigned this Feb 17, 2025
@hydra-yse hydra-yse force-pushed the yse-notification-update branch from ca315d7 to bbff09f Compare February 17, 2025 12:26
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@danielgranhao danielgranhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydra-yse hydra-yse merged commit 30a18f4 into main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants