delete pending payments unknown to the node #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
reviewed
Dec 5, 2024
JssDWt
force-pushed
the
jssdwt-remove-pending-payments
branch
from
800bdeb to
2c5548a
Compare
|
Updated to treat the payment inserted before sending the actual payment as a 'pseudo' payment. |
roeierez
approved these changes
Dec 5, 2024
dangeross
approved these changes
Dec 5, 2024
Before sending out a payment, the sdk inserts a pseudo payment. This ensures there is always a pending payment shown on clients directly when paying. If the call to send_payment never resulted in in actual payment being sent, these payments would sit in the database forever and never be deleted. Pseudo payments are now marked as pseudo in the database. On sync pseudo payments are deleted before inserting the updated payments from the node. Existing payments and sync state are dropped in case the client's database already contained pending payments because of this issue.
JssDWt
force-pushed
the
jssdwt-remove-pending-payments
branch
from
2c5548a to
2d69ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending out a payment, the sdk inserts a pseudo payment. This
ensures there is always a pending payment shown on clients directly when
paying. If the call to send_payment never resulted in in actual payment
being sent, these payments would sit in the database forever and never
be deleted. Pseudo payments are now marked as pseudo in the database. On
sync pseudo payments are deleted before inserting the updated payments
from the node.
Existing payments and sync state are dropped in case the client's
database already contained pending payments because of this issue.
Fixes #1139