Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/unit_tests.yml: Update it #887

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

t-b
Copy link
Contributor

@t-b t-b commented Feb 6, 2023

Only keep the last two major versions for sphinx and drop 4.x. In addition sphinx 6.0 dropped support for python 3.7, so we do the same.

Both changes allow us to remove all matrix excludes.

Close #884

@t-b t-b mentioned this pull request Feb 6, 2023
@t-b t-b force-pushed the update-ci-and-sphinx-versions branch from 9d6e706 to 0da8792 Compare February 6, 2023 22:03
@michaeljones
Copy link
Collaborator

Thanks for the PR. It seems that the latest Sphinx doesn't support Python 3.7 despite 3.7 still being officially supported for the next 4 months. I assume that's fine.

Sphinx 4.5 was only released in March last year though. Might it still be reasonable to support it for a bit or are there signs that the ecosystem is leaving it behind? @jakobandersen - do you have any thoughts on this?

Only keep the last two major versions for sphinx and drop 4.x. In addition
sphinx 6.0 dropped support for python 3.7, so we do the same.

Both changes allow us to remove all matrix excludes.
@t-b
Copy link
Contributor Author

t-b commented Feb 10, 2023

My reasoning was that supporting the current and previous major version of sphinx should be enough.

I also pushed a fix as I forgot to update requirements/production.txt.

@t-b t-b force-pushed the update-ci-and-sphinx-versions branch from 0da8792 to abe8c39 Compare February 10, 2023 12:01
@AA-Turner AA-Turner merged commit 0b2c40a into breathe-doc:main Jul 30, 2024
6 of 32 checks passed
@t-b t-b deleted the update-ci-and-sphinx-versions branch July 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle Sphinx 6.x
3 participants