Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt friendclass to Doxygen 1.9 #618

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

jakobandersen
Copy link
Collaborator

From Doxygen 1.9.0 the XML for friend class declarations has changed, e.g.,::

       <memberdef kind="friend" id="classBar_1a549e901751cbd1b0dd39326270e23ca6" prot="private" static="no" const="no" explicit="no" inline="no" virt="non-virtual">
-        <type>friend class</type>
+        <type>class</type>
         <definition>friend class Foo</definition>
         <argsstring></argsstring>
         <name>Foo</name>
+        <param>
+          <type><ref refid="classFoo" kindref="compound">Foo</ref></type>
+        </param>
         <briefdescription>
         </briefdescription>
         <detaileddescription>
         </detaileddescription>
         <inbodydescription>
         </inbodydescription>
         <location file="foo.h" line="6" column="5" bodyfile="foo.h" bodystart="6" bodyend="-1"/>
       </memberdef>

Fixes #616.

@jakobandersen
Copy link
Collaborator Author

I think the CI will go further when #617 has been merged.

@vermeeren vermeeren self-assigned this Jan 7, 2021
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @jakobandersen , indeed makes sense based upon XML diff. I'll check if the tests pass properly after #617 is merged for Sphinx 3.4.x compatibility.

vermeeren added a commit that referenced this pull request Jan 7, 2021
@michaeljones michaeljones merged commit 5970160 into breathe-doc:master Jan 8, 2021
@jakobandersen jakobandersen deleted the friendclass branch January 8, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError in visit_friendclass
3 participants