Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure for Sphinx >= 2.2.2 #472

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Fix test failure for Sphinx >= 2.2.2 #472

merged 1 commit into from
Feb 2, 2020

Commits on Feb 1, 2020

  1. Fix test failure for Sphinx >= 2.2.2 

    Sphinx changed the way it retrieves the CDomain in
sphinx-doc/sphinx@e42d546
to no longer use env.domaindata, but env.get_domain instead.

This breaks the mocks setup by breathe as they were implicitly only populatin
env.domaindata by invoking the constructor of the C and C++ domains (see
sphinx.domains.__init__: Domain.__init__). To properly populate the environment,
we need to make the mocked registry aware of the registered domains. Since we
only care about the C and C++ domain, we simply make it return both in
create_domains(), which registers them properly in the environment.
    @D4N
    D4N committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    a872100 View commit details
    Browse the repository at this point in the history