Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for the duplicate ID issue #224

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions breathe/directive/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def render(self, node_stack, project_info, options, filter_, target_handler, mas
renderer_factory_creator = self.renderer_factory_creator_constructor.create_factory_creator(
project_info,
self.state.document,
options,
options, # not used in the call
target_handler
)

Expand All @@ -83,6 +83,9 @@ def render(self, node_stack, project_info, options, filter_, target_handler, mas
except FileIOError as e:
return format_parser_error("doxygenclass", e.error, e.filename, self.state, self.lineno)

context = RenderContext(node_stack, mask_factory, self.directive_args)
# Quick hack to get it working: inject options here
directive_args = self.directive_args[:]
directive_args[2] = options
context = RenderContext(node_stack, mask_factory, directive_args)
object_renderer = renderer_factory.create_renderer(context)
return object_renderer.render()
2 changes: 1 addition & 1 deletion breathe/directives.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def resolve_function(self, matches, args, project_info):
# Iterate over the potential matches
for entry in matches:

text_options = {'no-link': u'', 'outline': u''}
text_options = {'no-link': u'', 'outline': u''} # this is never used

# Render the matches to docutils nodes
target_handler = self.target_handler_factory.create_target_handler(
Expand Down
1 change: 1 addition & 0 deletions breathe/renderer/rst/doxygen/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ def __init__(

def create_factory_creator(self, project_info, document, options, target_handler):

# the argument `options` is never used
return DoxygenToRstRendererFactoryCreator(
self.node_factory,
self.parser_factory,
Expand Down