Skip to content
This repository has been archived by the owner on Mar 19, 2020. It is now read-only.

Compare numerical keys as integers, not strings (fixes #27) #28

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Feb 14, 2019

No description provided.

@fmarier fmarier self-assigned this Feb 14, 2019
@fmarier
Copy link
Member Author

fmarier commented Feb 15, 2019

I wrote a script to parse the contents of the .dat files and here's the difference before and after my fix:

$ diff -u datbefore.out datafter.out 
--- datbefore.out	2019-02-15 15:29:30.500346889 -0800
+++ datafter.out	2019-02-15 15:30:01.271852039 -0800
@@ -1,4 +1,4 @@
-nb_trackers = 1871
+nb_trackers = 1879
 103092804.com
 1rx.io
 247realmedia.com
@@ -205,6 +205,7 @@
 adscale.de
 adscience.nl
 adserver.com
+adserver.yahoo.com
 adserverplus.com
 adserverpub.com
 adservice.google.com
@@ -272,6 +273,7 @@
 adviva.net
 advombat.ru
 adwitserver.com
+adwords.google.com
 adworx.at
 adworx.be
 adworx.nl
@@ -894,6 +896,7 @@
 hipcricket.com
 histats.com
 hit-parade.com
+hitbox.com
 hitslink.com
 hitsniffer.com
 hitsprocessor.com
@@ -1061,6 +1064,7 @@
 lockerdome.com
 lockerz.com
 logdy.com
+login.yahoo.com
 longboardmedia.com
 lookery.com
 loomia.com
@@ -1153,6 +1157,7 @@
 microad.jp
 millennialmedia.com
 mindset-media.com
+mindshare.nl
 mineralt.io
 mirando.de
 mixpanel.com
@@ -1359,6 +1364,7 @@
 pop6.com
 popads.net
 popadscdn.net
+popcde.com
 poprule.com
 popularmedia.com
 popunder.ru
@@ -1721,6 +1727,7 @@
 v12data.com
 v12group.com
 valuead.com
+valueclick.com
 valueclick.net
 valueclickmedia.com
 valuedopinions.co.uk
@@ -1826,6 +1833,7 @@
 yandex.ru/clck/counter
 yandex.ru/cycounter
 yandex.ru/portal/set/any
+yandex.ru/set/s/rsya-tag-users/data
 ybrantdigital.com
 ybx.io
 yceml.net
@@ -1952,7 +1960,7 @@
 adnetik.com: adnetik.com,wtp101.com
 adnetwork.net: adnetwork.net
 adnologies.com: adnologies.com,heias.com
-adobe.com: 2o7.net,auditude.com,demdex.com,demdex.net,dmtracker.com,efrontier.com,everestads.net,everestjs.net,everesttech.net,omniture.com,omtrdc.net,touchclarity.com,adobedtm.com
+adobe.com: 2o7.net,auditude.com,demdex.com,demdex.net,dmtracker.com,efrontier.com,everestads.net,everestjs.net,everesttech.net,hitbox.com,omniture.com,omtrdc.net,touchclarity.com,adobedtm.com
 adocean-global.com: adocean-global.com,adocean.pl
 adometry.com: adometry.com,dmtry.com
 adomik.com: adomik.com
@@ -2326,7 +2334,7 @@
 godatafeed.com: godatafeed.com
 goldbachgroup.com: goldbachgroup.com,goldbach.com
 goldspotmedia.com: goldspotmedia.com
-google.com: 2mdn.net,admeld.com,admob.com,cc-dt.com,destinationurl.com,developers.google.com,doubleclick.net,gmail.com,google-analytics.com,mail.google.com,inbox.google.com,plus.google.com,plusone.google.com,voice.google.com,wave.google.com,googleadservices.com,googlemail.com,googlesyndication.com,googletagservices.com,invitemedia.com,orkut.com,postrank.com,smtad.net,teracent.com,teracent.net,ytsa.net,googletagmanager.com,adservice.google.com
+google.com: 2mdn.net,admeld.com,admob.com,cc-dt.com,destinationurl.com,developers.google.com,doubleclick.net,gmail.com,google-analytics.com,adwords.google.com,mail.google.com,inbox.google.com,plus.google.com,plusone.google.com,voice.google.com,wave.google.com,googleadservices.com,googlemail.com,googlesyndication.com,googletagservices.com,invitemedia.com,orkut.com,postrank.com,smtad.net,teracent.com,teracent.net,ytsa.net,googletagmanager.com,adservice.google.com
 gosquared.com: gosquared.com
 gostats.com: gostats.com
 grapeshot.co.uk: grapeshot.co.uk
@@ -2625,7 +2633,7 @@
 precisionclick.com: precisionclick.com
 predictad.com: predictad.com
 pressflex.com: blogads.com,pressflex.com
-primevisibility.com: adcde.com,addlvr.com,adonnetwork.com,adonnetwork.net,adtrgt.com,bannertgt.com,cptgt.com,cpvfeed.com,cpvtgt.com,primevisibility.com,sdfje.com,urtbk.com
+primevisibility.com: adcde.com,addlvr.com,adonnetwork.com,adonnetwork.net,adtrgt.com,bannertgt.com,cptgt.com,cpvfeed.com,cpvtgt.com,popcde.com,primevisibility.com,sdfje.com,urtbk.com
 proclivitymedia.com: proclivitymedia.com,proclivitysystems.com,pswec.com
 projectwonderful.com: projectwonderful.com
 pronunciator.com: pronunciator.com,visitorville.com
@@ -2819,7 +2827,7 @@
 usitechnologies.com: upsellit.com,usitechnologies.com
 v12data.com: v12group.com,v12data.com
 valuead.com: valuead.com
-valueclick.com: adserver.com,dotomi.com,dtmpub.com,emjcd.com,fastclick.com,fastclick.net,greystripe.com,lduhtrp.net,mediaplex.com,valueclick.net,valueclickmedia.com
+valueclick.com: adserver.com,dotomi.com,dtmpub.com,emjcd.com,fastclick.com,fastclick.net,greystripe.com,lduhtrp.net,mediaplex.com,valueclick.com,valueclick.net,valueclickmedia.com
 various.com: amigos.com,getiton.com,medley.com,nostringsattached.com,various.com
 vcmedia.vn: vcmedia.vn
 vdopia.com: ivdopia.com,vdopia.com
@@ -2866,15 +2874,15 @@
 wordstream.com: wordstream.com
 wowanalytics.co.uk: wowanalytics.co.uk
 wp.pl: adtotal.pl,wp.pl
-wpp.com: 247realmedia.com,accelerator-media.com,acceleratorusa.com,decdna.net,decideinteractive.com,gmads.net,groupm.com,kantarmedia.com,mecglobal.com,mookie1.com,pm14.com,realmedia.com,targ.ad,themig.com,wpp.com,xaxis.com,compete.com
+wpp.com: 247realmedia.com,accelerator-media.com,acceleratorusa.com,decdna.net,decideinteractive.com,gmads.net,groupm.com,kantarmedia.com,mecglobal.com,mindshare.nl,mookie1.com,pm14.com,realmedia.com,targ.ad,themig.com,wpp.com,xaxis.com,compete.com
 wysistat.com: wysistat.com
 xad.com: xad.com
 xertivemedia.com: admanager-xertive.com,xertivemedia.com
 xplosion.de: xplosion.de
 xplusone.com: ru4.com,xplusone.com
 yabuka.com: yabuka.com
-yahoo.com: adinterax.com,adrevolver.com,bluelithium.com,dapper.net,interclick.com,overture.com,rightmedia.com,rmxads.com,secure-adserver.com,advertising.yahoo.com,marketingsolutions.yahoo.com,thewheelof.com,yieldmanager.com,yieldmanager.net,yldmgrimg.net,analytics.yahoo.com,mybloglog.com,rocketmail.com,address.yahoo.com,alerts.yahoo.com,avatars.yahoo.com,buzz.yahoo.com,calendar.yahoo.com,edit.yahoo.com,legalredirect.yahoo.com,mail.yahoo.com,my.yahoo.com,notepad.yahoo.com,pulse.yahoo.com,webmessenger.yahoo.com,ymail.com
-yandex.com: web-visor.com,moikrug.ru,an.yandex.ru,adfox.yandex.ru,awaps.yandex.ru,mc.yandex.ru,yandex.ru/cycounter,yandex.ru/clck/click,yandex.ru/clck/counter,yandex.ru/portal/set/any
+yahoo.com: adinterax.com,adrevolver.com,bluelithium.com,dapper.net,interclick.com,overture.com,rightmedia.com,rmxads.com,secure-adserver.com,adserver.yahoo.com,advertising.yahoo.com,marketingsolutions.yahoo.com,thewheelof.com,yieldmanager.com,yieldmanager.net,yldmgrimg.net,analytics.yahoo.com,mybloglog.com,rocketmail.com,address.yahoo.com,alerts.yahoo.com,avatars.yahoo.com,buzz.yahoo.com,calendar.yahoo.com,edit.yahoo.com,legalredirect.yahoo.com,login.yahoo.com,mail.yahoo.com,my.yahoo.com,notepad.yahoo.com,pulse.yahoo.com,webmessenger.yahoo.com,ymail.com
+yandex.com: web-visor.com,moikrug.ru,an.yandex.ru,adfox.yandex.ru,awaps.yandex.ru,mc.yandex.ru,yandex.ru/cycounter,yandex.ru/clck/click,yandex.ru/clck/counter,yandex.ru/set/s/rsya-tag-users/data,yandex.ru/portal/set/any
 ybrantdigital.com: addynamix.com,adserverplus.com,oridian.com,ybrantdigital.com
 ybx.io: ybx.io
 ydworld.com: ydworld.com,yieldivision.com

I also wrote another script to parse the Disconnect JSON file and can confirm that the .dat file generator now outputs all of the Disconnect trackers.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++
Awesome catch @fmarier! Thanks you.

@bbondy
Copy link
Member

bbondy commented Feb 16, 2019

nice work @fmarier

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants