This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Make Autofill as a PersonalDataManagerObserver #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Oct 11, 2016
fix #4349 requires brave/muon#70 Auditors: @bridiver Test Plan: 1. Prepare a fresh install brave (version > 0.12.3) 2. Lauch brave 3. open about:autofill 4. Add an address 5. The address entry should show on the page 6. Add a credit card 7. The credit card entry should show on the page 8. Verify address and credit card on http://www.roboform.com/filling-test-all-fields
4 tasks
bridiver
reviewed
Oct 11, 2016
| autofill::PersonalDataManagerFactory::GetForBrowserContext( | ||
| browser_context_); | ||
| if (!personal_data) { | ||
| if (!personal_data_manager_) { | ||
| LOG(ERROR) << "No Data"; |
There was a problem hiding this comment.
can we emit an event for these errors so we can inform the user about them on the browser side? Just open a new ticket for now so we don't forget about it
|
++ |
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Oct 11, 2016
fix #4349 requires brave/muon#70 Auditors: @bridiver Test Plan: 1. Prepare a fresh install brave (version > 0.12.3) 2. Lauch brave 3. open about:autofill 4. Add an address 5. The address entry should show on the page 6. Add a credit card 7. The credit card entry should show on the page 8. Verify address and credit card on http://www.roboform.com/filling-test-all-fields
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Oct 11, 2016
fix #4349 requires brave/muon#70 Auditors: @bridiver Test Plan: 1. Prepare a fresh install brave (version > 0.12.3) 2. Lauch brave 3. open about:autofill 4. Add an address 5. The address entry should show on the page 6. Add a credit card 7. The credit card entry should show on the page 8. Verify address and credit card on http://www.roboform.com/filling-test-all-fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditor: @bridiver, @bbondy