This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Update incognito session initialization #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5, the values were changed from an exclusion (ex: which values to NOT put in `OverlayUserPrefStore`) to an inclusion (ex: which values to PERSIST, even in an incognito profile) Fixes brave/browser-laptop#15191
|
I renamed the variables/methods to match the renaming done upstream: See https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5%5E%21/#F4 for more info |
bsclifton
commented
Sep 13, 2018
| @@ -532,21 +532,18 @@ void BraveBrowserContext::CreateProfilePrefs( | |||
| bool async = false; | |||
|
|
|||
| if (IsOffTheRecord()) { | |||
| overlay_pref_names_.push_back("app_state"); | |||
| overlay_pref_names_.push_back(extensions::pref_names::kPrefContentSettings); | |||
| overlay_pref_names_.push_back(prefs::kPartitionPerHostZoomLevels); | |||
There was a problem hiding this comment.
Here's the actual important fix (above 3 lines); NOT passing these to what because an inclusion list for incognito pref key names
darkdh
approved these changes
Sep 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5, the values being registered in a session were changed from an exclusion (ex: which values to NOT put in
OverlayUserPrefStore) to an inclusion (ex: which values to PERSIST, even in an incognito profile)Fixes brave/browser-laptop#15191