crash reporting #279

bridiver · 2017-08-21T20:29:11Z

re-enable crash reporting

posix4e · 2017-08-21T22:02:20Z

chromium_src/chrome/browser/profiles/profile_manager.cc

@@ -351,6 +313,11 @@ ProfileManager::ProfileInfo* ProfileManager::GetProfileInfoByPath(
  return (iter == profiles_info_.end()) ? NULL : iter->second.get();
 }

+// static
+void ProfileManager::NukeDeletedProfilesFromDisk() {
+  // TODO(bridiver)


Maybe we should create an issue for this?

posix4e · 2017-08-21T22:03:13Z

patches/master_patch.patch

+
+   # DON'T ADD MORE FLAGS HERE. Read the comment above.
+  # Build chromium without muon flags
+  muon_chromium_build = false


so confusing. Hah! Good catch.

posix4e · 2017-08-21T22:04:09Z

atom/app/atom_main.cc

@@ -6,13 +6,18 @@

 #include <stdlib.h>

+#include <memory>


There's a lot going on this commit. Maybe we should have a bit more context to review what's going on in this commit.

I split it up into multiple commits for that reason

posix4e · 2017-08-21T22:05:17Z

atom/app/atom_main.cc

+    return crash_reporter::RunAsCrashpadHandler(
+        *base::CommandLine::ForCurrentProcess(), switches::kProcessType);
+  } else if (process_type == crash_reporter::switches::kFallbackCrashHandler) {
+    // return RunFallbackCrashHandler(*command_line);


What's to happen here?

posix4e · 2017-08-21T22:08:22Z

chromium_src/chrome/browser/browser_process_impl.cc

 }

 void BrowserProcessImpl::PreMainMessageLoopRun() {
+  TRACE_EVENT0("startup", "BrowserProcessImpl::PreMainMessageLoopRun");


Trace event? What's going on here?

posix4e

I hope you find my comments useful. In no way do I wish to block the merging. I am very excited about all of the red in these commits but am having a hard time saying for sure that I understand everything going on.

darkdh · 2017-08-26T04:13:03Z

build/BUILD.gn

-    "$root_gen_dir/electron",
-    "//electron/vendor/brightray",
+    "$root_gen_dir/chrome",
+    "$root_gen_dir/components/strings",
    "//electron/vendor/native_mate",


Why these //electron* dirs aren't included in muon_include_dirs_

darkdh · 2017-08-26T04:21:40Z

patches/master_patch.patch

+  default_compiler_configs -= [ "//build/config/compiler:default_include_dirs" ]
+  default_compiler_configs += [
+    "//electron/build:muon_include_dirs",
+    "//build/config/compiler:default_include_dirs"


does the order of configs matter here?

yes, it does. Include dirs are searched in the order they are added

bridiver · 2017-09-08T01:05:44Z

patches/master_patch.patch

+                                             kXdgConfigHomeEnvVar,
+                                             kDotConfigDir));
+-#if defined(GOOGLE_CHROME_BUILD)
+#if defined(GOOGLE_CHROME_BUILD) || !defined(MUON_CHROMIUM_BUILD)


check to see if this is still needed

brave/muon#279

user-data-dir -> user-data-dir-name add muon api for crash reporter in renderer

crash reporting

@bridiver

brave/muon#279 Auditors: @bridiver, @bsclifton

@bridiver

Auditors: @bridiver, @bsclifton

@bridiver

Auditors: @bridiver, @bsclifton

brave/muon#279

Address changes of crash reporter in brave/muon#279

brave/muon#279

bridiver added branch-4.4.x branch-4.5.x branch-4.6.x labels Aug 21, 2017

bridiver added this to the 4.4.8 milestone Aug 21, 2017

bridiver self-assigned this Aug 21, 2017

bridiver requested review from bbondy and darkdh August 21, 2017 20:29

posix4e reviewed Aug 21, 2017

View reviewed changes

posix4e previously approved these changes Aug 21, 2017

View reviewed changes

bridiver dismissed posix4e’s stale review via 37792f7 August 23, 2017 23:27

bridiver force-pushed the issue-230 branch from 6ab31d5 to b3db70b Compare August 24, 2017 00:51

bridiver changed the title ~~Issue 230~~ crash reporting Aug 25, 2017

darkdh reviewed Aug 26, 2017

View reviewed changes

bridiver force-pushed the issue-230 branch 11 times, most recently from 76fede0 to d457b91 Compare August 30, 2017 02:26

bridiver commented Sep 8, 2017

View reviewed changes

darkdh mentioned this pull request Sep 8, 2017

Overrides user-data-dir by exe name on Windows #276

Closed

bridiver added a commit to brave/browser-laptop that referenced this pull request Sep 29, 2017

use new crash reporter api

f8cb7d4

brave/muon#279

bridiver added 3 commits September 29, 2017 20:09

fix crash reporter

be85e8e

user-data-dir -> user-data-dir-name add muon api for crash reporter in renderer

lint fixes

355ef09

fix rebase issues

5e80203

bridiver force-pushed the issue-230 branch from f48ce32 to 5e80203 Compare September 30, 2017 03:09

bridiver merged commit fec6974 into master Sep 30, 2017

bridiver added a commit that referenced this pull request Sep 30, 2017

Merge pull request #279 from brave/issue-230

baa1d19

crash reporting

bridiver added the merged/branch-4.5.x label Sep 30, 2017

darkdh added a commit to brave/electron-squirrel-startup that referenced this pull request Sep 30, 2017

Address changes of crash reporter in

4415943

brave/muon#279 Auditors: @bridiver, @bsclifton

darkdh added a commit to brave/electron-installer-debian that referenced this pull request Sep 30, 2017

Address changes of crash reporter in brave/muon#279

222e273

Auditors: @bridiver, @bsclifton

darkdh added a commit to brave/electron-installer-redhat that referenced this pull request Sep 30, 2017

Address changes of crash reporter in brave/muon#279

3653f6c

Auditors: @bridiver, @bsclifton

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 6, 2017

use new crash reporter api

8137a17

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 6, 2017

use new crash reporter api

3fd920b

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 6, 2017

use new crash reporter api

0aa9ac7

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 7, 2017

use new crash reporter api

35f2d60

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 7, 2017

use new crash reporter api

6af6dc2

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 11, 2017

use new crash reporter api

111a46b

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 11, 2017

use new crash reporter api

1f9bf99

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 13, 2017

use new crash reporter api

39bd844

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 13, 2017

use new crash reporter api

760a2b0

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 13, 2017

use new crash reporter api

f9d850d

brave/muon#279

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 13, 2017

use new crash reporter api

6137217

brave/muon#279

This was referenced Oct 14, 2017

renderer crashes are missing version #212

Closed

add crash keys api for crash reporting #230

Closed

Use chromium spellcheck provider #147

Closed

bbondy pushed a commit to brave/browser-laptop that referenced this pull request Oct 18, 2017

use new crash reporter api

b191663

brave/muon#279

bbondy added a commit to brave/electron-installer-debian that referenced this pull request Oct 27, 2017

Merge pull request #2 from brave/muon-issue-230

5f37713

Address changes of crash reporter in brave/muon#279

bbondy added a commit to brave/electron-installer-redhat that referenced this pull request Oct 27, 2017

Merge pull request #2 from brave/muon-issue-230

442d0c8

Address changes of crash reporter in brave/muon#279

syuan100 pushed a commit to syuan100/browser-laptop that referenced this pull request Nov 9, 2017

use new crash reporter api

d2794f2

brave/muon#279

bsclifton deleted the issue-230 branch June 18, 2018 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

crash reporting #279

crash reporting #279

bridiver commented Aug 21, 2017

posix4e Aug 21, 2017

posix4e Aug 21, 2017

posix4e Aug 21, 2017

bridiver Aug 29, 2017

posix4e Aug 21, 2017

posix4e Aug 21, 2017

posix4e left a comment

darkdh Aug 26, 2017

darkdh Aug 26, 2017

bridiver Aug 29, 2017

bridiver Sep 8, 2017

crash reporting #279

crash reporting #279

Conversation

bridiver commented Aug 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

posix4e left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment