This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Fix SetCookieWithDetailsAsync with failure callback #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
reviewed
Jul 20, 2017
| // Only append * for .domain | ||
| if (base::StartsWith(base::UTF16ToUTF8(host_key), | ||
| ".", base::CompareCase::INSENSITIVE_ASCII)) { | ||
| host.append(base::UTF8ToUTF16("*")); |
There was a problem hiding this comment.
shouldn't '*' go at the beginning of the host, not at the end?
There was a problem hiding this comment.
yeah, it appends to the empty string16 object
There was a problem hiding this comment.
oops i got host and host_key mixed up
There was a problem hiding this comment.
does this need changes then?
There was a problem hiding this comment.
host_key is extracted from sql and it will be directly used as ImportedCookieEntry.domain
host is determined by host_key and will be used as ImportedCookieEntry.host
diracdeltas
approved these changes
Jul 27, 2017
bridiver
added a commit
that referenced
this pull request
Jul 28, 2017
Fix SetCookieWithDetailsAsync with failure callback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/browser-laptop#10043
Auditors: @bridiver, @diracdeltas, @bbondy