This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
autoplay block no longer conflicts with timeline change pause #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
May 19, 2017
| // If we're already playing, then this play would do nothing anyway. | ||
| // Call playInternal to handle scheduling the promise resolution. | ||
| - if (!m_paused) { | ||
| + if (!m_paused || m_hasPlayed) { |
There was a problem hiding this comment.
I'm not sure I understand why this is necessary. Once a user has given autoplay permission, it should last at least for the duration of the site visit. I think this is a browser-laptop issue and not a muon issue
There was a problem hiding this comment.
no, it is actually blocked on muon side.
When users start playing video, it will not block. But as user drag timeline , some sites like vimeo or netflix will trigger a pause() first, and that will cause m_paused to be true and it won't continue playing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#8897
Auditors: @bridiver, @bbondy