This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
Helper methods for summarizing contributions and CSV export (browser-laptop#3477) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2016 10:39
- Client#_publisherVoteData([viewingIds]) get a contribution summary organized by publisher for 1, N (an array), or all transactions (useful for brave/browser-laptop#3477) - Client#_totalContribution([viewingIds]) get the total amount contributed in BTC and fiat for 1, N (an array), or all transactions - Client#_transactionByViewingId(viewingId) (self-explanatory)
4 tasks
mrose17
suggested changes
Sep 26, 2016
| @@ -275,6 +275,160 @@ Client.prototype.ballots = function (viewingId) { | |||
| return count | |||
| } | |||
|
|
|||
| Client.prototype._totalContribution = function (viewingIds) { | |||
There was a problem hiding this comment.
what is the entry point that users of this module are going to access? it should be the function that doesn't start with a "_" and is defined between ballots and vote, the other functions should be defined between _updatedRules and _roundtrip
There was a problem hiding this comment.
it's _getTransactionCSVText, which shouldn't begin with an underscore
|
|
||
| var rows = [headerRow] | ||
|
|
||
| rows = rows.concat(publishers.map(function (pub) { |
There was a problem hiding this comment.
shouldn't there be some kind of CSV quoting for the publisher name?
| pubRow.votes, | ||
| pubRow.fraction, | ||
| pubRow.contribution.satoshis / Math.pow(10, 10), | ||
| pubRow.contribution.fiat.toFixed(2) + ' ' + pubRow.contribution.currency |
There was a problem hiding this comment.
you should add a comment such as
// TBD: update later to reflect correct number of fixed points for fiat currency in use
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CSV export for ledger transaction/contribution data by publisher
supports brave/browser-laptop#3477
needed for PR brave/browser-laptop#4312
A couple contribution summary helper methods:
get a contribution summary organized by publisher for 1, N (an array), or all transactions
(useful for ledger transaction history should have receipt links browser-laptop#3477)
get the total amount contributed in BTC and fiat for 1, N (an array), or all transactions