History type support #176
Merged
History type support #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use client_tag_hash as ID for history type - No tag items needed for history type - No version checking for history type when update records
DJAndries
force-pushed
the
history-type-support
branch
from
f1cf8aa to
d4e8a43
Compare
DJAndries
force-pushed
the
history-type-support
branch
from
d4e8a43 to
57be8f4
Compare
DJAndries
commented
Oct 7, 2023
schema/dynamodb/table.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| ], | |||
| "GlobalSecondaryIndexes": [ | |||
| { | |||
| "IndexName": "ClientIDDataTypeMtimeIndex", | |||
| "IndexName": "ClientIDDataTypeMtimeIndexV2", | |||
There was a problem hiding this comment.
a db change is needed for this to work:
- enabling ttl for the
ExpirationTimeattribute
DJAndries
force-pushed
the
history-type-support
branch
from
f9c2404 to
a1ec741
Compare
yrliou
reviewed
Oct 11, 2023
DJAndries
force-pushed
the
history-type-support
branch
from
a1ec741 to
862e79d
Compare
25 tasks
yrliou
reviewed
Oct 12, 2023
Comment on lines
+251
to
+255
| log.Error().Err(err).Msg("Insert history sync entity failed") | ||
| rspType := sync_pb.CommitResponse_TRANSIENT_ERROR | ||
| entryRsp.ResponseType = &rspType | ||
| entryRsp.ErrorMessage = aws.String(fmt.Sprintf("Insert history sync entity failed: %v", err.Error())) | ||
| continue |
There was a problem hiding this comment.
nit: Maybe Error checking if client_unique_tag exists rather than Insert history sync entity failed is more clear?
yrliou
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new Chromium history type.
History sync entities will use the
ClientTagHashas a primary key, instead of theIdString. Differing version numbers between old and new items will be ignored when updating.