Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show full URL for tooltip inside braveryPanel #9491

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

cezaraugusto
Copy link
Contributor

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Auditors: @luixxiul, @diracdeltas
Close #9089

Test plan:

Both compact and full bravery panel should have the full URL described in host's title as a tooltip (element title).

@luixxiul I went ahead and aligned top-left header as well, pls review.

STR:

  1. visit https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/
  2. Open Bravery Panel
  3. Hover over host
  4. Tooltip should show full url

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@cezaraugusto cezaraugusto added this to the 0.18.x (Developer Channel) milestone Jun 15, 2017
@cezaraugusto cezaraugusto self-assigned this Jun 15, 2017
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cezaraugusto cezaraugusto merged commit 73ff1b1 into master Jun 19, 2017
@cezaraugusto cezaraugusto deleted the braveryPanel/9089 branch June 19, 2017 04:29
cezaraugusto added a commit that referenced this pull request Jun 19, 2017
Show full URL for tooltip inside braveryPanel
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants