Normalize buttons in about:preferences #9487
Conversation
|
The buttons on
See: ee832b2#diff-799b11467a9bfc86f7dbbf11fcaee159R477 which should be addressed with By applying it the buttons should be look like this:
|
|
Also @cezaraugusto, would you please create an issue to track the TODOs? |
There was a problem hiding this comment.
LGTM except
- Add
browserButton_panelItemon browserButton.js to apply the style to the buttons on bitcoinDashboard.js (Add browserButton_panelItem to BrowserButton component #9543) - Add
panelItemto style.js
Auditors: @luixxiul Test Plan: Buttons inside prefs should look the same across tabs
cezaraugusto
force-pushed
the
buttons/9486
branch
from
ee832b2
to
0572679
Compare
|
thanks, updated
sorry but which to-dos? |
js/about/styles.js
Outdated
| @@ -312,6 +312,13 @@ class AboutStyle extends ImmutableComponent { | |||
| <BrowserButton iconOnly icon={'{'}globalStyles.appIcons.private{'}'} size='60px' color='red' /> | |||
| </Code></Pre> | |||
|
|
|||
| <BrowserButton groupedItem secondaryColor panelItem l10nId='panelItem' onClick={this.onEnableAutoplay} /> | |||
| <BrowserButton groupedItem primaryColor panelItem l10nId='panelItem' onClick={this.onEnableAutoplay} /> | |||
There was a problem hiding this comment.
Maybe this.copyToClipboard and this.props.showQRcode look better, which are actually only used on bitcoinDashboard.js for now.
js/about/styles.js
Outdated
| <BrowserButton groupedItem primaryColor panelItem l10nId='panelItem' onClick={this.onEnableAutoplay} /> | ||
| <Pre><Code> | ||
| <BrowserButton groupedItem secondaryColor panelItem l10nId='panelItem' onClick={'{this.onEnableAutoplay}'} />{'\n'} | ||
| <BrowserButton groupedItem primaryColor panelItem l10nId='panelItem' onClick={'{this.onEnableAutoplay}'} /> |
cezaraugusto
force-pushed
the
buttons/9486
branch
from
0572679
to
6f70a1c
Compare
|
ok updated example. re #9487 (comment) I preferred to create a tracking issue for prefs refactoring: #9558, given we'll naturally remove those comments once refactored. lmk if that sounds good to you |
Normalize buttons in about:preferences
Addresses #9223
Fixes #9543
Submitter Checklist:
git rebase -ito squash commits (if needed).Don't need PR #9357 but will preferably land after that
Auditors: @luixxiul
Test Plan:
Buttons inside prefs should look the same across tabs
Reviewer Checklist:
Tests