Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

handle exit signals cleanly #9374

Merged
merged 1 commit into from
Jun 10, 2017
Merged

handle exit signals cleanly #9374

merged 1 commit into from
Jun 10, 2017

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jun 9, 2017

possible fix for #9373

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver added the bug label Jun 9, 2017
@bridiver bridiver added this to the 0.16.9 milestone Jun 9, 2017
@bridiver bridiver requested review from bbondy and bsclifton June 9, 2017 23:19
@bridiver bridiver self-assigned this Jun 9, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed Brave does properly close on ctrl + c, when given kill signal (ex: from Task manager), and when installation happens while Brave is open

@bsclifton bsclifton merged commit d66351b into master Jun 10, 2017
@bsclifton bsclifton deleted the exit-signals branch June 10, 2017 00:03
bsclifton added a commit that referenced this pull request Jun 10, 2017
handle exit signals cleanly
bsclifton added a commit that referenced this pull request Jun 10, 2017
handle exit signals cleanly
bsclifton added a commit that referenced this pull request Jun 10, 2017
handle exit signals cleanly
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants