Active tab update issue

[bridiver]

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

Fixes #8974

Test Plan:

Reviewer Checklist:

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[bsclifton]

Needs more tests and also needs to be merged to master. Important to note this includes behavior changing when closing tabs which @bridiver reviewed with @bradleyrichter

++! 👍

[bsclifton]

retested original test case (ctrl + w issue) and it failed ☹️

[bsclifton]

I think a new Muon version is needed (build is in progress). This includes the following patch:
brave/muon@4fdf666

When using this code as-is, I was able to cause an issue by setting tab close behavior to the default (parent). Will retest when new Muon is available 😄

[bsclifton]

After the Muon PR, the issues I saw were fixed 👍

I think he only remaining issue is:
Behaviors for close (when you pick one of the three options) don't seem to work as described

[bsclifton]

My setup:
2 pinned tabs (https://slashdot.org/, https://www.roboform.com/filling-test-all-fields)

select the last viewed tab - this always seems to be choosing the 2nd pinned tab, no matter what I do

select the next tab - this behavior is inconsistent. Sometimes, it picks the previous tab, sometimes it picks what seems to be a random tab (maybe the previous index?). If I have two tabs open and try to close the first, it selects the first pinned tab.

select its parent tab - this seems to be working for the most part. It doesn't always select the parent though. If I open the same link via middle clicking 3 times, closing one of them chooses another one (not necessarily the opener)

[bridiver]

I pushed a fix for "last active", but I can't replicate any issues with "next tab". "parent" should only go back to the parent if it is also the last active tab, otherwise it should go to "next"

[bsclifton]

Fixes work great 😄