This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes tab title on tab update #8992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
May 21, 2017
| @@ -92,7 +92,7 @@ const frameReducer = (state, action, immutableAction) => { | |||
| } | |||
| } | |||
|
|
|||
| const title = immutableAction.getIn(['changeInfo', 'title']) | |||
| const title = immutableAction.getIn(['tabValue', 'title']) | |||
There was a problem hiding this comment.
this may help, but won't be a complete fix because it doesn't address the race condition. Getting the title from tabValue will only fix the title when the tab state changes for some other reason. I think this change is ok for now, but we should add a comment/TODO that the race condition with appState is the real problem
There was a problem hiding this comment.
we also shouldn't mark this as resolving the issue for the same reason
There was a problem hiding this comment.
Currently the only problem with the title not updating is when you use navigation buttons, so when tab state changes. What should I wrote in todo? TODO fix race condition with appState
Resolves brave#8908 Auditors: @bsclifton @bridiver Test Plan: - go to site clifton.io - create a history - click on back/forward buttons - check that title is always correct
NejcZdovc
force-pushed
the
hotfix/#8908-title
branch
from
7f2f9fb to
591f054
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #8908
Auditors: @bsclifton @bridiver
Test Plan:
Reviewer Checklist:
Tests