This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove CommonFormSection from widevineInfo.js #8911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as widevineInfo is also used outside of widevinePanel.js Fixes #8907 Auditors: Test Plan 1: 1. Open about:preferences#plugins 2. Make sure there is margin between the divs, the div and the switch Test Plan 2: 1. Open netflix.com 2. Make sure the dialog design is not affected by this change
srirambv
approved these changes
May 17, 2017
|
@Jacalz What's up with the milestone? |
luixxiul
modified the milestones:
0.19.x (Developer Channel),
tart,
0.17.13 (Release Channel)
|
What the ****, I have not even touched the milestones, might be time to change password 😅 Strange 😬 |
|
The strange thing is that only my devices are connected in the security log, but I went and enabled two factor authentication to be sure 😉😬 Sorry for what happened 🤦♂️ |
|
np! |
|
I had removed the milestone earlier and also I updated your comment above @Jacalz (let's keep in clean in here please 😄 ). Maybe your phone was unlocked in your pocket while viewing this page? |
|
Sorry, got really confused and frustrated 🙂 Have never happened before but let's say that it was that unless it happens again 😅 I am very sorry and actually glad that it wasn't anything huge that changed 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as widevineInfo is also used outside of widevinePanel.js
Fixes #8907
Auditors:
Test Plan 1:
Test Plan 2:
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests