Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bump electron-installer-redhat to 0.5.0 #8859

Merged
merged 1 commit into from
May 26, 2017
Merged

Bump electron-installer-redhat to 0.5.0 #8859

merged 1 commit into from
May 26, 2017

Conversation

da2x
Copy link
Contributor

@da2x da2x commented May 12, 2017

Versions prior to 0.5.0 don't run update-desktop-database on post-install and post-uninstall. This causes the Brave icon to not appear in GNOME/KDE/others after installation (user must install another package or reboot) and cause it not disappear when uninstalled for the same reason.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run indivually or as a suite ref

Versions prior to 0.5.0 don't run `update-desktop-database` on post-install and post-uninstall. This causes the Brave icon to not appear in GNOME/KDE/others after installation (user must install another package or reboot) and cause it not disappear when uninstalled for the same reason.
@luixxiul
Copy link
Contributor

@da2x would you mind letting us know how and what to test on this PR? thanks!

@da2x
Copy link
Contributor Author

da2x commented May 17, 2017

@luixxiul, build environment should install electron-installer-redhat 0.5.0 or newer. (0.5.0 is the current stable release.)

The specific change from this release that is important to Brave is the new icon installation process. To test this, if you don’t trust upstream, is to setup a new Fedora Workstation release in a virtual machine (like VirtualBox). Install the rpm file with dnf install ./brave-release.rpm. Now open the Activity menu (top left corner of GNOME), and search for Brave. Brave should be available, with icon and all, immediately without first having to log out and back in again to the system. This improves the first-install experience by making Brave available in the application dashboard immediately.

@bbondy
Copy link
Member

bbondy commented May 26, 2017

Posted this issue for tracking:
#9074

@bbondy
Copy link
Member

bbondy commented May 26, 2017

++

@bbondy bbondy merged commit 06ee049 into brave:master May 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants