This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactors window actions, remove the whole frame prop (related to tabs) #8858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
NejcZdovc
force-pushed
the
refactor/#8857-actions
branch
4 times, most recently
from
96db833
to
8b86455
Compare
5 tasks
NejcZdovc
force-pushed
the
refactor/#8857-actions
branch
from
2b60f29
to
20039a1
Compare
|
found one possible problem, checking it out |
|
nvm, this also happens on the master, so it's not related to this PR |
NejcZdovc
force-pushed
the
refactor/#8857-actions
branch
3 times, most recently
from
d599d26
to
571f92f
Compare
Resolves brave#8857 Auditors: @bsclifton @bridiver Test Plan: - try closing a tab - hover over the tab and close button should be displayed - resize window and check if tabs are changing (when really small, text should be hidden) - reorder tabs with dnd - try tabs tear off - try moving tabs from one window to another - try moving tab into next tab page, by dropping it on the tab page indicator - try moving bookmark into bookmark folder - try reordering bookmarks - check if tab preview is working
NejcZdovc
force-pushed
the
refactor/#8857-actions
branch
from
571f92f
to
b9aa47a
Compare
bsclifton
added
refactoring/redux-component
feature/tabsbar
and removed
PR/needs-QA-attention ☕
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #8857
Auditors: @bsclifton @bridiver
Test Plan:
Reviewer Checklist:
Tests