This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
fix applySiteSettingRecord error, remove unneeded setObjectId calls #8242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #8241 applySiteSettingRecord should not need to check if there is a diff between the existing record and the new record; this is the job of reducers. Auditors: @ayumi Test Plan: 1. 'Syncing' tests should pass 2. Set isProduction to true in js/constants/appConfig 3. Sync to the profile starting with "duality" (sent via slack DM) 4. You should not see any console errors 5. Go http://expectnothing.com/ and verify that shields are down
ayumi
approved these changes
Apr 12, 2017
| @@ -918,8 +914,6 @@ const handleAppAction = (action) => { | |||
|
|
|||
| if (result === undefined) { | |||
| let newSiteSettings = siteSettings.mergeSiteSetting(appState.get('siteSettings'), pattern, 'ledgerPayments', true) | |||
| const syncObject = siteUtil.setObjectId(newSiteSettings.get(pattern)) | |||
| newSiteSettings = newSiteSettings.set(pattern, syncObject) | |||
There was a problem hiding this comment.
minor: can newSiteSettings be const?
There was a problem hiding this comment.
Pls do audited commit if changing, I'll merge this in the meantime. Thanks.
This was referenced Apr 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8241
applySiteSettingRecord should not need to check if there is a diff between
the existing record and the new record since that should be the job of reducers
Auditors: @ayumi
Test Plan:
git rebase -ito squash commits (if needed).Test Plan: