Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix 'beta' logo alignment, add it to sync tab #8198

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Apr 10, 2017

address #8121 (comment) and makes the logo look the same on sync and payments tabs

fix #8121

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:
go to about:preferences, check that the 'beta' logo is on the sync and payments tabs and looks the same.

address #8121 (comment) and makes the logo look the same on sync and payments tabs
@diracdeltas diracdeltas added this to the 0.14.2 milestone Apr 10, 2017
Copy link
Contributor

@bradleyrichter bradleyrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pre-approve if Sync and Payments looks similar. Both are major features and deserve the logo-like style treatment compared to the normal grey titles in other panels.

@bsclifton
Copy link
Member

@bradleyrichter here's how they look 😄

screen shot 2017-04-10 at 1 11 12 pm

screen shot 2017-04-10 at 1 11 20 pm

@diracdeltas diracdeltas merged commit 125c87a into master Apr 10, 2017
@diracdeltas diracdeltas deleted the fix/beta-alignment branch April 10, 2017 20:23
@luixxiul
Copy link
Contributor

Regressed #7750

screenshot 2017-04-11 19 29 43

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added temporary notice to sync prefs page regarding mobile sync and Beta label
4 participants