Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replace -webkit-user-select with user-select #8125

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Replace -webkit-user-select with user-select #8125

merged 1 commit into from
Apr 9, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 8, 2017 •
edited
Loading

Closes #8124

Auditors:

Test Plan: n/a

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Apr 8, 2017
@luixxiul luixxiul added this to the 0.14.2 milestone Apr 8, 2017
@luixxiul luixxiul self-assigned this Apr 8, 2017
@luixxiul luixxiul requested a review from NejcZdovc April 8, 2017 06:53
NejcZdovc
NejcZdovc suggested changes Apr 9, 2017
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still found some WebkitUserSelect in files, can you please check again and replace everything with userSelect

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 9, 2017

done

NejcZdovc
NejcZdovc approved these changes Apr 9, 2017
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luixxiul luixxiul merged commit 0a932de into brave:master Apr 9, 2017
@luixxiul luixxiul deleted the user-select branch April 9, 2017 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

Assignees

@luixxiul luixxiul

Labels
polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @NejcZdovc