This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Various URL bar related design fixes #8059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
added
design
NejcZdovc
requested review from
luixxiul,
cezaraugusto,
bsclifton and
bradleyrichter
bradleyrichter
approved these changes
Apr 3, 2017
luixxiul
reviewed
Apr 4, 2017
less/navigationBar.less
Outdated
| color: #333; | ||
| box-shadow: inset 0 0 0 1px #bbb, inset 0 0 0 3px rgba(55, 169, 253, 0.4); |
There was a problem hiding this comment.
Let's replace #bbb and rgba(55, 169, 253, 0.4) with variables and add them to variables.less and global.js for future refactoring work.
luixxiul
reviewed
Apr 4, 2017
| @@ -132,11 +132,10 @@ const styles = StyleSheet.create({ | |||
| WebkitAppRegion: 'no-drag', | |||
| borderWidth: '1px 1px 1px 0px', | |||
| borderStyle: 'solid', | |||
| borderColor: '#CBCBCB', | |||
| borderColor: '#BBB', | |||
There was a problem hiding this comment.
Let's apply the variable for box-shadow of navigationBar.less.
Resolves brave#8058 Auditors: @bradleyrichter @bsclifton Test Plan: - specified in brave#8058
NejcZdovc
force-pushed
the
hotfix/#8058-url
branch
from
8d8a749
to
94e02ef
Compare
|
@luixxiul can you please review it again? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Resolves #8058
Auditors
@bradleyrichter @bsclifton
Test Plan