This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Payments features 1.0 #7642
Merged
Payments features 1.0 #7642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
from
819f9fd
to
b9c3e58
Compare
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
from
b9c3e58
to
a24b1b2
Compare
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
11 times, most recently
from
921aa3d
to
52a9ec3
Compare
This was referenced Mar 21, 2017
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
2 times, most recently
from
a8b397f
to
132de84
Compare
NejcZdovc
requested review from
mrose17,
alexwykoff,
bsclifton and
bradleyrichter
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
7 times, most recently
from
dfcd1ea
to
4239016
Compare
|
many thanks! |
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
from
27a7be0
to
2bf1018
Compare
Resolves brave#7347 Resolves brave#6890 Auditors: @bsclifton @bradleyrichter @mrose17 Test plan: - npm run test -- --grep="LedgerTable" - npm run test -- --grep="Ledger table"
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
from
2bf1018
to
a404201
Compare
|
@cezaraugusto yes. Although I don't know which is easier to understand for usability. We could leave the switch enabled and allow a pinned site to be "excluded" which would be a macro for "un pin and set to zero %. |
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
5 times, most recently
from
863d582
to
385f5f8
Compare
NejcZdovc
force-pushed
the
feature/#7347-payment-features
branch
from
385f5f8
to
059caa8
Compare
4 tasks
bsclifton
approved these changes
Mar 30, 2017
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/needs-QA-attention ☕
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Resolves #7347
Auditors
@bsclifton @bradleyrichter @mrose17 @alexwykoff
Test plan
npm run test -- --grep="LedgerTable"npm run test -- --grep="Ledger table"