Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor ledgerBackupContent with Aphrodite #7383

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Refactor ledgerBackupContent with Aphrodite #7383

merged 1 commit into from
Feb 28, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 25, 2017

Closes #7382

  • copyKeyContainer
  • keyContainer
  • keyContainer__h3
  • keyContainer__span
  • recoveryContent__h4
  • ledgerRecoveryContent

Auditors: @cezaraugusto

Test Plan:

  1. Open about:preferences#payments
  2. Open Advanced Settings
  3. Open Backup your wallet
  4. Make sure the styling is not broken
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Closes #7382

- copyKeyContainer
- keyContainer
- keyContainer__h3
- keyContainer__span
- recoveryContent__h4
- ledgerRecoveryContent

Test Plan:
1. Open about:preferences#payments
2. Open Advanced Settings
3. Open Backup your wallet
4. Make sure the styling is not broken
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit a2315b5 into brave:master Feb 28, 2017
@luixxiul luixxiul deleted the paymentsTab-aphrodite branch February 28, 2017 16:21
@luixxiul luixxiul restored the paymentsTab-aphrodite branch February 28, 2017 16:21
@luixxiul luixxiul added this to the 0.13.5 milestone Feb 28, 2017
@luixxiul luixxiul deleted the paymentsTab-aphrodite branch March 24, 2017 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants